[PATCH] Remove mibank wrapper

Adam Jackson ajax at nwnk.net
Mon Jan 4 14:21:49 PST 2010


On Mon, 2010-01-04 at 13:18 -0800, Keith Packard wrote:
> On Mon,  4 Jan 2010 15:32:49 -0500, Adam Jackson <ajax at redhat.com> wrote:
> 
> > +static int
> > +miScanLineWidth(
> 
> Is there any driver still using this function? I'd rather see it
> disappear than live on without having any users.

No driver uses it.  But xf86ValidateModes (alone, hence static) does,
which is why I moved it to xf86Mode.c.  And does so in more than one
place, so the factorization still makes sense.

> Also, if it does need to survive, the copyright messages from mibank.c
> will need to get merged into xf86Mode.c

Nggh, yeah.  I'm trying to find _good_ attribution of this code, and not
having much success.  It doesn't exist in XFree86 3.3.6, which appears
to be the only 3.x release that's easily findable on the interwebs
anymore.  (Thanks, guys.)  According to

http://cvsweb.xfree86.org/cvsweb/xc/programs/Xserver/mi/mibank.c

it was birthed whole into XFree86 3.9jf, including all the
Goei/Roell/SGCS attribution.  I really can't be bothered to find the
original Roell code to see if miScanLineWidth existed there.  I kind of
doubt that it did, it reads like tsi code.

- ajax
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
Url : http://lists.x.org/archives/xorg-devel/attachments/20100104/6f26788f/attachment.pgp 


More information about the xorg-devel mailing list