[PATCH 1/4] [kdrive] Remove trailing whitespace

Mikhail Gusarov dottedmag at dottedmag.net
Sun Jan 3 23:55:48 PST 2010


Twas brillig at 16:04:50 04.01.2010 UTC+11 when daniel at fooishbar.org did gyre and gimble:

 >> >> any particular reason this patch is needed? It touches a lot of files but
 >> >> doesn't actually improve the code.
 >> >
 >> > I checked with git diff -b and saw that it changed nothing; as it
 >> > just eliminates a pile of trailing white space. Makes it easier to
 >> > change the code in the future as you don't have to worry about
 >> > accidentally removing trailing whitespace and having diffs cluttered
 >> > with that.
 >> >
 >> > I'm in favor of this kind of cleanup; anyone else have an opinion?
 >> 
 >> If it's done manually rather than mechanically, it'll be undone by
 >> another edit using cut/paste, etc.

 DS> echo 'let c_space_errors=1' >> ~/.vimrc

 DS> Or just let the reviewer pick it up.  Or, or ...

Yep, once fixed it won't be reintroduced so easily (and I did not see
lots of trailing whitespace in other parts of X server). My intention
was the one Keith mentioned: keep whitespace and functionality changes
separate.

-- 
  http://fossarchy.blogspot.com/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
Url : http://lists.x.org/archives/xorg-devel/attachments/20100104/f61a4bf4/attachment.pgp 


More information about the xorg-devel mailing list