[PATCH] silent: Set AM_DEFAULT_VERBOSITY for compatibility on older automake

[Gaetan Nadon]

On Sun, 2010-02-28 at 08:01 -0800, Dan Nicholson wrote:

> On Sat, Feb 27, 2010 at 1:45 PM, Gaetan Nadon <memsize at videotron.ca> wrote:
> > On Sat, 2010-02-27 at 13:08 -0800, Dan Nicholson wrote:
> >
> > On Sat, Feb 27, 2010 at 12:53 PM, Gaetan Nadon <memsize at videotron.ca> wrote:
> >> On Sat, 2010-02-27 at 11:32 -0800, Dan Nicholson wrote:
> >>
> >> Custom silent rules will become recursive on older automake where
> >> AM_SILENT_RULES is not included. Set AM_DEFAULT_VERBOSITY in this
> >> fallback case for compatibility.
> >>
> >> Signed-off-by: Dan Nicholson <dbn.lists at gmail.com>
> >> ---
> >>  I hit this error in xts when a couple people tried to run the test
> >>  suite against older hosts.
> >>
> >>  xorg-macros.m4.in |    3 ++-
> >>  1 files changed, 2 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/xorg-macros.m4.in b/xorg-macros.m4.in
> >> index 7ba0c9a..478e5fe 100644
> >> --- a/xorg-macros.m4.in
> >> +++ b/xorg-macros.m4.in
> >> @@ -935,7 +935,8 @@ XORG_RELEASE_VERSION
> >>  XORG_CHANGELOG
> >>  XORG_INSTALL
> >>  XORG_MANPAGE_SECTIONS
> >> -m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])])
> >> +m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])],
> >> +    [AC_SUBST([AM_DEFAULT_VERBOSITY], [1])])
> >>  ]) # XORG_DEFAULT_OPTIONS
> >>
> >>  # XORG_INSTALL()
> >>
> >> Reviewed-by: Gaetan Nadon <memsize at videotron.ca>
> >>
> >> Out of curiosity, how old an Automake are we talking about? Our minimum is
> >> 1.9 (latest is 1.9.6) which works fine.
> >
> > Any automake that doesn't have AM_SILENT_RULES, which is why we have
> > the m4_ifdef around it. I don't remember what version of automake this
> > was added in, but I don't see the automake version being enforced in
> > any modules.
> >
> > This was introduced in 1.11. I think it has more to do with this, but I am
> > not sure:
> >
> > The current implementation of this feature relies on a non-POSIX, but in
> > practice rather widely supported Makefile construct of nested variable
> > expansion ‘$(var1$(V))’. Do not use the silent-rules option if your package
> > needs to build with make implementations that do not support it. The
> > silent-rules option turns off warnings about recursive variable expansion,
> > which are in turn enabled by -Wportability (see Invoking Automake).
> >
> > I like to hear about non mainstream platforms in terms of portability and
> > toolchain limitations.
> 
> I'm not sure I see what the portability of silent-rules has to do with
> this patch.
> 

The patch is ok, push anytime you want. Sorry for the noise.

> --
> Dan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100228/0da6d3c0/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100228/0da6d3c0/attachment.pgp>