[PATCH] Use libtool -export-dynamic flag for portability

[Dan Nicholson]

On Wed, Feb 24, 2010 at 1:15 AM, Yaakov (Cygwin/X)
<yselkowitz at users.sourceforge.net> wrote:
> From: Yaakov Selkowitz <yselkowitz at users.sourceforge.net>
>
> The linker flag required for exporting symbols in executables varies
> by platform.  libtool handles this with a single -export-dynamic
> flag (not to be confused with the similarly-named ELF linker flag)
> which tells it to use the correct platform-specific flag at link time.
>
> Signed-off-by: Yaakov Selkowitz <yselkowitz at users.sourceforge.net>
> ---
>  configure.ac |   14 +++-----------
>  1 files changed, 3 insertions(+), 11 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index 5e6669d..eae9a41 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1439,17 +1439,9 @@ UTILS_SYS_LIBS="${SYS_LIBS}"
>  AC_SUBST([UTILS_SYS_LIBS])
>
>  # The Xorg binary needs to export symbols so that they can be used from modules
> -# Some platforms require extra flags to do this.   gcc should set these flags
> -# when -rdynamic is passed to it, other compilers/linkers may need to be added
> -# here.
> -if test "x$GCC" = "xyes"; then
> -       LD_EXPORT_SYMBOLS_FLAG="-rdynamic"
> -fi
> -case $host_os in
> -       openbsd*)
> -       LD_EXPORT_SYMBOLS_FLAG="-Wl,--export-dynamic"
> -       ;;
> -esac
> +# Some platforms require extra flags to do this.   libtool should set the
> +# necessary flags for each platform when -export-dynamic is passed to it.
> +LD_EXPORT_SYMBOLS_FLAG="-export-dynamic"
>  AC_SUBST([LD_EXPORT_SYMBOLS_FLAG])

Since this isn't really variable, you can put it straight into AC_SUBST:

AC_SUBST([LD_EXPORT_SYMBOLS_FLAG], [-export-dynamic])

Either way,

Reviewed-by: Dan Nicholson <dbn.lists at gmail.com>

--
Dan