[PATCH xserver 1/3] config: add -fno-strict-aliasing now that it is out of $CWARNFLAGS

Alan Coopersmith Alan.Coopersmith at Sun.COM
Tue Feb 23 10:54:44 PST 2010


But if it's not in patch 1, then bisecting will fail when it lands between
patch 1 & 2.   Removing it only makes sense if 1 & 2 get merged.

	-alan-

Jeremy Huddleston wrote:
> You're still have this which is not necessary due to your #2 patch:
> 
> +CWARNFLAGS="$CWARNFLAGS $ALIASING_CFLAGS"
> 
> --Jeremy
> 
> On Feb 23, 2010, at 10:37, Gaetan Nadon wrote:
> 
>> This patch will ensure the xserver continues to suppress the
>> optimization, based on strict aliasing rules, after the option
>> is removed from $CWARNFLAGS. There is no change in the object
>> code produced.
>>
>> There is no attempt to determine if xserver should or should not
>> have such an optimization. A new warning (-Wstrict-aliasing=2)
>> has been added to the XORG_CWARNFLAGS macro to help  find code
>> that may interfere with optimization.
>>
>> Reviewed-by: Jeremy Huddleston <jeremyhu at apple.com>
>> Signed-off-by: Gaetan Nadon <memsize at videotron.ca>
>> ---
>> configure.ac |    8 ++++++++
>> 1 files changed, 8 insertions(+), 0 deletions(-)
>>
>> diff --git a/configure.ac b/configure.ac
>> index b9c7574..2360cde 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -79,6 +79,14 @@ AC_SYS_LARGEFILE
>> XORG_PROG_RAWCPP
>> AC_PATH_PROG(SED,sed)
>>
>> +# Suppress strict aliasing optimization
>> +ALIASING_CFLAGS=
>> +if test "x$GCC" = xyes; then
>> +    ALIASING_CFLAGS=-fno-strict-aliasing
>> +fi
>> +AC_SUBST([ALIASING_CFLAGS])
>> +CWARNFLAGS="$CWARNFLAGS $ALIASING_CFLAGS"
>> +
>> # Quoted so that make will expand $(CWARNFLAGS) in makefiles to allow
>> # easier overrides at build time.
>> XSERVER_CFLAGS='$(CWARNFLAGS)'
>> -- 
>> 1.6.0.4
>>
>> _______________________________________________
>> xorg-devel mailing list
>> xorg-devel at lists.x.org
>> http://lists.x.org/mailman/listinfo/xorg-devel
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> xorg-devel mailing list
> xorg-devel at lists.x.org
> http://lists.x.org/mailman/listinfo/xorg-devel

-- 
	-Alan Coopersmith-           alan.coopersmith at sun.com
	 Oracle Solaris Platform Engineering: X Window System



More information about the xorg-devel mailing list