[xserver patch v8 4/5] dri2: Support the DRI2InvalidateBuffers event.

Jesse Barnes jbarnes at virtuousgeek.org
Tue Feb 23 09:38:41 PST 2010


On Tue, 23 Feb 2010 13:30:22 +0100
Francisco Jerez <currojerez at riseup.net> wrote:

> Bumps the supported DRI2 protocol version.
> 
> Signed-off-by: Francisco Jerez <currojerez at riseup.net>
> ---
> v8: s/PreConfigureWindow/ConfigNotify/
> 
>  configure.ac                |    2 +-
>  hw/xfree86/dri2/dri2.c      |  110
> +++++++++++++++++++++++++++++++++++++++++++
> hw/xfree86/dri2/dri2.h      |    4 ++ hw/xfree86/dri2/dri2ext.c   |
> 56 +++++++++++++++++++++- include/protocol-versions.h |    2 +-
>  5 files changed, 169 insertions(+), 5 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index de252f3..e9ca45a 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -759,7 +759,7 @@ RECORDPROTO="recordproto >= 1.13.99.1"
>  SCRNSAVERPROTO="scrnsaverproto >= 1.1"
>  RESOURCEPROTO="resourceproto"
>  DRIPROTO="xf86driproto >= 2.1.0"
> -DRI2PROTO="dri2proto >= 2.2"
> +DRI2PROTO="dri2proto >= 2.3"
>  XINERAMAPROTO="xineramaproto"
>  BIGFONTPROTO="xf86bigfontproto >= 1.2.0"
>  XCALIBRATEPROTO="xcalibrateproto"
> diff --git a/hw/xfree86/dri2/dri2.c b/hw/xfree86/dri2/dri2.c
> index 48618e1..30edb00 100644
> --- a/hw/xfree86/dri2/dri2.c
> +++ b/hw/xfree86/dri2/dri2.c
> @@ -52,6 +52,14 @@ static DevPrivateKey dri2WindowPrivateKey =
> &dri2WindowPrivateKeyIndex; static int dri2PixmapPrivateKeyIndex;
>  static DevPrivateKey dri2PixmapPrivateKey =
> &dri2PixmapPrivateKeyIndex; 
> +typedef struct _DRI2ClientRef *DRI2ClientRefPtr;
> +
> +struct _DRI2ClientRef {
> +    DRI2ClientRefPtr	 next;
> +    XID			 resource;
> +    void	       (*invalidate)(DrawablePtr, XID);
> +};
> +
>  typedef struct _DRI2Drawable {

Patch looks correct, but maybe we should pull the list implementation
from xf86-video-intel this time?  I ended up not needing it for the
last bit of DRI2 protocol, but it looks like it would help this time.
That could be done as a separate patch though.

Reviewed-by: Jesse Barnes <jbarnes at virtuousgeek.org>

-- 
Jesse Barnes, Intel Open Source Technology Center


More information about the xorg-devel mailing list