[PATCH xserver 1/3] config: add -fno-strict-aliasing now that it is out of $CWARNFLAGS

[Jeremy Huddleston]

With your 2/3, you don't need this any more:

> +CWARNFLAGS="$CWARNFLAGS $ALIASING_CFLAGS"

Also, can you remove XQuartz from the changes in 2/3.  I'm 99% certain XQuartz is strict-aliasing safe, and if not, I want to see the fallout, so I can fix it.

Thanks,
Jeremy

On Feb 23, 2010, at 06:13, Gaetan Nadon wrote:

> This patch will ensure the xserver continues to suppress the
> optimization, based on strict aliasing rules, after the option
> is removed from $CWARNFLAGS. There is no change in the object
> code produced.
> 
> There is no attempt to determine if xserver should or should not
> have such an optimization. A new warning (-Wstrict-aliasing=2)
> has been added to the XORG_CWARNFLAGS macro to help  find code
> that may interfere with optimization.
> 
> Reviewed-by: Jeremy Huddleston <jeremyhu at apple.com>
> Signed-off-by: Gaetan Nadon <memsize at videotron.ca>
> ---
> configure.ac |    8 ++++++++
> 1 files changed, 8 insertions(+), 0 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index b9c7574..2360cde 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -79,6 +79,14 @@ AC_SYS_LARGEFILE
> XORG_PROG_RAWCPP
> AC_PATH_PROG(SED,sed)
> 
> +# Suppress strict aliasing optimization
> +ALIASING_CFLAGS=
> +if test "x$GCC" = xyes; then
> +    ALIASING_CFLAGS=-fno-strict-aliasing
> +fi
> +AC_SUBST([ALIASING_CFLAGS])
> +CWARNFLAGS="$CWARNFLAGS $ALIASING_CFLAGS"
> +
> # Quoted so that make will expand $(CWARNFLAGS) in makefiles to allow
> # easier overrides at build time.
> XSERVER_CFLAGS='$(CWARNFLAGS)'
> -- 
> 1.6.0.4
> 
> Reposting single patch as the first of a serie due to dependencies
> 
> 
> 
> 
> _______________________________________________
> xorg-devel mailing list
> xorg-devel at lists.x.org
> http://lists.x.org/mailman/listinfo/xorg-devel