[PATCH 1/3 (v3)] os: always check if client is local when connection is accepted
daniel at fooishbar.org
Fri Dec 31 04:26:00 PST 2010
On Fri, Dec 31, 2010 at 12:52:25PM +0200, Pauli Nieminen wrote:
> On Fri, Dec 31, 2010 at 11:55 AM, Daniel Stone <daniel at fooishbar.org> wrote:
> > LocalClient is used for all DRI2 requests that makes it frequently
> > called function. Querying if connection is local or not takes 10-15us
> > (on ARM) depending on malloc speed.
> > Signed-off-by: Pauli Nieminen <ext-pauli.nieminen at nokia.com>
> > Reviewed-by: Daniel Stone <daniel at fooishbar.org>
> I did same changes except comment down there. It works for me perfectly fine.
> Thanks for your help.
> (yes. Nokia mail server doesn't like to delivery mails just now)
Ah yes, seems familiar. :)
> > diff --git a/include/os.h b/include/os.h
> > index d747040..99a7002 100644
> > --- a/include/os.h
> > +++ b/include/os.h
> > @@ -353,6 +353,7 @@ typedef struct sockaddr * sockaddrPtr;
> > extern _X_EXPORT int InvalidHost(sockaddrPtr /*saddr*/, int /*len*/, ClientPtr client);
> > +extern Bool ComputeLocalClient(ClientPtr /* client */);
> > extern _X_EXPORT int LocalClient(ClientPtr /* client */);
> Would it better to have this in internal header like os/osdep.h?
You're right - I'll move it there in my local tree.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: Digital signature
More information about the xorg-devel