[PATCH v2 09/12] mi: Only register sprite block handler when needed

[Daniel Stone]

Hi,

On Thu, Dec 30, 2010 at 07:19:40PM +0200, Pauli wrote:
> @@ -383,7 +390,6 @@ miSpriteCloseScreen (int i, ScreenPtr pScreen)
>      pScreen->GetImage = pScreenPriv->GetImage;
>      pScreen->GetSpans = pScreenPriv->GetSpans;
>      pScreen->SourceValidate = pScreenPriv->SourceValidate;
> -    pScreen->BlockHandler = pScreenPriv->BlockHandler;
>      pScreen->InstallColormap = pScreenPriv->InstallColormap;
>      pScreen->StoreColors = pScreenPriv->StoreColors;

It's still good form to tear the block handler down, and there's no
reason it should run after CloseScreen.  So, I'd say change this to:
if (pScreenPriv->BlockHandler)
    pScreen->BlockHandler = pScreenPriv->BlockHandler;

Aside from that:
Reviewed-by: Daniel Stone <daniel at fooishbar.org>

Cheers,
Daniel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg-devel/attachments/20101231/2971ed2d/attachment.pgp>