[PATCH] xfree86: Fix Xasprinf/Xasprintf typo.

Alan Coopersmith alan.coopersmith at oracle.com
Thu Dec 30 15:48:06 PST 2010


On 12/30/10 03:43 PM, Cyril Brulebois wrote:
> It was introduced during the *printf conversion (d2c42b10).
> 
> Signed-off-by: Cyril Brulebois <kibi at debian.org>
> ---
>  hw/xfree86/dixmods/extmod/modinit.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/hw/xfree86/dixmods/extmod/modinit.c b/hw/xfree86/dixmods/extmod/modinit.c
> index 168795d..1c7c58d 100644
> --- a/hw/xfree86/dixmods/extmod/modinit.c
> +++ b/hw/xfree86/dixmods/extmod/modinit.c
> @@ -146,7 +146,7 @@ extmodSetup(pointer module, pointer opts, int *errmaj, int *errmin)
>      for (i = 0; extensionModules[i].name != NULL; i++) {
>  	if (opts) {
>  	    char *s;
> -	    if (Xasprinf(&s, "omit%s", extensionModules[i].name) != -1) {
> +	    if (Xasprintf(&s, "omit%s", extensionModules[i].name) != -1) {
>  		pointer o;
>  		o = xf86FindOption(opts, s);
>  		free(s);

No, don't use Xasprintf, use:
http://lists.x.org/archives/xorg-devel/2010-December/017477.html

And if you like it, give it a Reviewed-by, so that it doesn't sit abandoned in
the mailing list archives forever.

-- 
	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System



More information about the xorg-devel mailing list