[PATCH modular 03/13] build.sh: allow user to specify an alternate bin directory

Trevor Woerner twoerner at gmail.com
Wed Dec 29 16:31:12 PST 2010

On Wed, Dec 29, 2010 at 10:44 AM, Gaetan Nadon <memsize at videotron.ca> wrote:
> +# Set the default value for BINDIR
> +if [ X"$BINDIR_SET" = X ]; then
> +    BINDIR=$EPREFIX/bin
> +fi

I wonder if the above snippet (and all other such snippets from this
patch set) could be moved into the setup_buildenv() function? I
believe the purpose of that function is to define/setup various
default values. Moving these snippets there too will keep all the
variable defining/setting all in one place?

I'm guessing you already thought of this, though, because you have
added various checks to the setup_buildenv() function for these

In the case where "build.sh -L" is called all this environment setup
isn't required, and is one of the reasons why all that code was moved
into that function.

More information about the xorg-devel mailing list