[PATCH modular 04/13] build.sh: allow user to specify an alternate datadir

Matt Dew matt at osource.org
Wed Dec 29 12:01:04 PST 2010


On Wed, Dec 29, 2010 at 12:51 PM, Thomas Dickey <dickey at his.com> wrote:
> On Wed, 29 Dec 2010, Gaetan Nadon wrote:
>
>> On Wed, 2010-12-29 at 12:22 -0700, Matt Dew wrote:
>>
>>>
>>> There's no issues with:
>>> ${DESTDIR}${DATADIR}
>>> vs:
>>> ${DESTDIR}/${DATADIR}
>>> ?
>>>
>>> DESTDIR will always end in '/' right?
>>>
>>
>> All the *DIR variables which are installation directories must be
>> absolute paths.
>> This is now checked by the script.
>>
>> DESTDIR might be $HOME for example. It would be /home/matt/usr/local/bin
>> for the bin directory.
>> In the help text we had a '/' for clarity, I suppose.
>
> Usually DESTDIR is empty (no trailing slash in that case).  Whatever
> follows it should of course be an absolute path.
>
> ymmm
>
> --
> Thomas E. Dickey
> http://invisible-island.net
> ftp://invisible-island.net
>

Ok.  That was the only thing that stuck out to me.  I'm glad to see
this patch series.

Reviewed-by: Matt Dew <matt at osource.org>


More information about the xorg-devel mailing list