[PATCH util/modular] build.sh: add xrestop

Tiago Vignatti tiago.vignatti at nokia.com
Wed Dec 29 09:42:26 PST 2010


On Wed, Dec 29, 2010 at 11:48:48AM -0500, ext Gaetan Nadon wrote:
> On Wed, 2010-12-29 at 18:20 +0200, Tiago Vignatti wrote:
> 
> > On Wed, Dec 29, 2010 at 10:50:16AM -0500, ext Gaetan Nadon wrote:
> > > On Wed, 2010-12-29 at 10:16 -0500, Gaetan Nadon wrote:
> > > > 
> > > > Can I trouble you to add in the commit text the motivation for adding
> > > > this app?
> > > > I generally like to comment why packages are added/removed from
> > > > build.sh.
> > 
> > ...
> >  
> > > I was under the assumption that this app is an X.Org app, but it has a 
> > > GNU General Public License which I vaguely recall not being appropriate
> > > for X.Org.
> > > Would this app be released along all the other ones on the X.Org
> > > website?
> > > 
> > > There is a lot of configuration upgrade to do, but this app may abide by
> > > other rules.
> > 
> > Are we releasing only MIT based stuff within katamari? 
> > 
> > if build.sh matches exactly what gets released in X katamari then this patch
> > probably is invalid. Are we doing in such way?
> > 
> >              Tiago
> 
> 
> I am not sure what "MIT based stuff" means, but I just did a grep on
> everything in build.sh
> and I see no GNU General Public License except for mesa, which is not an
> X.Org module.
> 
> The latest LICENSING is here:
> http://www.x.org/releases/X11R7.6/doc/xorg-docs/License.html
> It does not say anything about about GNU GPL. I just recall some
> discussion on the list to the effect
> that this license is too restrictive.
> 
> The problem I see with it's inclusion in build.sh is that it is error
> prone from a maintenance point of view.
> How is anyone supposed to know this module is different from all the
> other ones. Updating COPYING is different,
> the standard README would probably not point to X.Org, and so on.
> 
> I started upgrading the configuration with some standard pre-reviewed
> xorg stuff, 
> so I will probably have to revert the patches.
> 
> Build.sh contains more than a katamari. It's all xorg modules +
> mesa/xcb/keyboard-config/pixman
> and a number modules that are not in high demand or near obsolete. 

okay Gaetan.

I'll pass the ball now to you and you decide if you want to apply or not the
patch. 


Thanks for checking it!

             Tiago


More information about the xorg-devel mailing list