[PATCHES] Multitouch v4 - please review

Fernando Carrijo fcarrijo.lists at gmail.com
Wed Dec 29 06:45:46 PST 2010


Daniel Stone <daniel at fooishbar.org> wrote:

> Hi all,
> I've published v4 of my multitouch patches, addressing (I think) all the
> review comments from v3.  libXi and xf86-input-evdev are untouched, but
> xserver has seen a great deal of cleanups, xinput some minor tweaks, and
> inputproto has had the usecases expanded upon, etc.
> 
> I'm attaching the inputproto, xserver and xinput patches as replies to
> this mail, but as always, these can be found from:
>     git://people.freedesktop.org/~daniels/inputproto
>     git://people.freedesktop.org/~daniels/xserver
>     git://people.freedesktop.org/~daniels/libXi
>     git://people.freedesktop.org/~daniels/xinput
>     git://people.freedesktop.org/~daniels/xf86-input-evdev
> in the 'multitouch' branches, or 'multitouch-cumulative' as well for
> inputproto.
> 
> The xserver tree is based on whot/for-keith, which lags master somewhat,
> but applies cleanly to master as well.
> 
> Cheers,
> Daniel

I'm far from being an expert in the X input subsystem, but I just finished
inspecting this patch series and they seemed all okay to my eyes. If I can
not guarantee the semantical correctness of all the code you guys wrote, I
can at least endorse the pieces I fully understood. Grab processing is yet
a bit obscure to me.

But hopefully I'll be more helpful in the future.

Good work, guys!


More information about the xorg-devel mailing list