[RFC] [PATCH 7/8] [resourceproto] xXResQueryResourceBytesReply: fixed too small record by adding more padding

Tiago Vignatti tiago.vignatti at nokia.com
Wed Dec 29 04:23:05 PST 2010


On Mon, Dec 27, 2010 at 04:57:01PM +0200, ext Erkki Sepp�l� wrote:
> ---
>  XResproto.h |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
> 
> diff --git a/XResproto.h b/XResproto.h
> index 883af13..26d503d 100644
> --- a/XResproto.h
> +++ b/XResproto.h
> @@ -210,8 +210,12 @@ typedef struct {
>     CARD8   pad1;
>     CARD16  sequenceNumber B16;
>     CARD32  length B32;
> -   CARD32  numSizes;
> +   CARD32  numSizes B32;
>     CARD32  pad2 B32;
> +   CARD32  pad3 B32;
> +   CARD32  pad4 B32;
> +   CARD32  pad5 B32;
> +   CARD32  pad6 B32;
>     // followed by numSizes times XResResourceSizeValue
>  } xXResQueryResourceBytesReply;
>  #define sz_xXResQueryResourceBytesReply  32

I haven't checked the real need of this changes, but you may want to squash
this commit together with the previous one and send again to the list:
http://gitorious.org/erkkise/x11proto-resource/commit/56da638e7f6bad7a131101d18b2ac3ef0fd6c92a

             Tiago


More information about the xorg-devel mailing list