[PATCH v2 4/4] composite: Copy the window contents back from the pixmap

[Ville Syrjälä]

On Mon, Dec 27, 2010 at 10:45:35AM -0800, ext Keith Packard wrote:
> On Mon, 27 Dec 2010 20:30:06 +0200, Ville Syrjälä <ville.syrjala at nokia.com> wrote:
> 
> > We're going through this codepath when getting rid of an implicitly
> > redirected window. That is at least one case where the depths won't
> > match.
> 
> I don't understand -- the only pixmap ever passed to compRestoreWindow
> was just recently returned from GetWindowPixmap. Are you saying that
> there are times when that pixmap doesn't match the depth of the window?

It's comparing the depth of the window, and it's parent.

The window's pixmap will be switched to the parent's pixmap before
compRestoreWindow() will be called. Since the window's and it's
parent's depths might not match, the window's and it's current
pixmap's depth may not necessarily match either. But just for a
very brief period during window destruction, I think.

-- 
Ville Syrjälä