[PATCH v4 xserver 0/3] Client ID tracking

Rami Ylimäki rami.ylimaki at vincit.fi
Thu Dec 23 04:11:37 PST 2010

Fixes based on comments of various reviewers. The changes are also
available at clientids branch of

Mark Kettenis:
    move /proc specific code into os
    treat pid -1 as error instead of 0
Tiago Vignatti:
    preserve copyrights
    amend authorship
    add description of the framework
    use doxygen style
    rename cmd -> cmdline in ClientIdsPrivateRec
    compile only if XRES or XSELINUX is enabled

Fernando Carrijo:
    don't use -o or -a with "test" shell command
Tiago Vignatti:
    use doxygen @file directive
    move pid_t related functions into os
    remove unnecessary header inclusions
    let client ID tracking be disabled with --disable-clientids
    create dummy stubs for initialization functions if disabled
    don't make XSELinux depend on client ID tracking
    squash copyrights into main commit
    don't add copyright for restructuring of minor code segments

Review comments not respected:
    don't install client ID tracking headers
    As soon as client ID tracking is incorporated into X server, it
    will be used from debugging code of at least one video driver.

Keith Packard:
    add fields to client record instead of using client privates
    move code from DIX to OS

Rami Ylimäki (3):
  config: Fix linking order of Xnest libraries.
  os: Add facilities for client ID tracking.
  Xext: Use general OS functions to determine client command string in

 Xext/xselinux_hooks.c        |   34 +++---
 configure.ac                 |   15 ++-
 dix/dispatch.c               |   10 ++
 dix/main.c                   |    3 +
 hw/xfree86/loader/sdksyms.sh |    1 +
 include/Makefile.am          |    1 +
 include/client.h             |   59 ++++++++
 include/dix-config.h.in      |    3 +
 include/dixstruct.h          |    2 +
 os/Makefile.am               |    1 +
 os/client.c                  |  310 ++++++++++++++++++++++++++++++++++++++++++
 11 files changed, 421 insertions(+), 18 deletions(-)
 create mode 100644 include/client.h
 create mode 100644 os/client.c

More information about the xorg-devel mailing list