kbproto compilation problem

[Gaetan Nadon]

On Tue, 2010-12-21 at 21:24 -0700, tom fogal wrote:

> Gaetan Nadon <memsize at videotron.ca> writes:
> > On Tue, 2010-12-21 at 14:10 -0700, tom fogal wrote:
> > 
> > > In the meantime, please consider the attached build.sh patch.  I
> > > used it to configure my X build --without-fop, on all packages.
> >
> > That answers a question I had. Had you noticed the CONFFLAGS variable
> > which is meant to hold such configuration option like --without-fop?
> > Probably not as it the name and the description was obscure.
> 
> Oh, no, I hadn't noticed it.
> 
> I guess it's just a personal preference of mine to (for the most part)
> ignore environment variables.  They're nice when you have a deep
> pipeline with a complex frontend and thus it's poke at the guts, but
> when I'm scripting or just typing in commands, I like the option I am
> setting to be tightly coupled with the command; it's more obvious when
> I need to look back at what I did.
> 
> > I was wondering if I should add an option on the build.sh command
> > line and your patch tells me I should. I like the option name you
> > have chosen.  Should I keep the CONFFLAGS as well?
> 
> Yes; IMHO it's always nice for an option to be backed by an env var.

Ok, good to know.

> 
> I do think that they should be named the same though; i.e. CONFFLAGS
> and --confflags or AUTOCONF and --autoconf.  I think AUTOCONF means
> something to `autoreconf' though, so I'd actually lean towards your
> original CONFFLAGS/--confflags, now that I think about it.

Ah, I see. --autoconf might look like an option that applies to
autoreconf itself rather than
a configure script option.

> 
> > I have a dozen patches in the pipeline, so I'll integrate yours. Feel
> > free to review the patches when posted.
> 
> Okay, and will do!
> 
> Thanks,
> 
> -tom


Thanks for the feedback.

Gaetan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20101222/87c69405/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-devel/attachments/20101222/87c69405/attachment-0001.pgp>