[PATCH:libX11 1/2] Bug 32098: Making XInternAtoms take const char ** breaks callers

Daniel Stone daniel at fooishbar.org
Wed Dec 22 03:31:27 PST 2010

On Tue, Dec 21, 2010 at 06:46:56PM -0800, Alan Coopersmith wrote:
> On 12/14/10 04:16 AM, Daniel Stone wrote:
> > Hm, I'm really not wild about this at all.  Getting all our types right
> > is hard enough as it is, and I suspect we're just going to have problems
> > with this leaking anyway.  What happens if a toolkit and an app, or an
> > app and a helper library, or whatever, disagree on whether or not the
> > arguments need to be const?
> > 
> > I'd say that we should just chalk this down as yet another Xlib API
> > mistake, and people who need it to be const can just do the cast, take
> > the warning if necessary, and move on with their lives.  Or move on to
> > XCB.
> Yeah, I hadn't thought through the issues of different levels of library
> & toolkit with different ideas about what's right.   I declare defeat and
> will revert the original change.

Sorry to harsh your buzz. :)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg-devel/attachments/20101222/90d85d91/attachment.pgp>

More information about the xorg-devel mailing list