Composite ClipNotify fix and expose event elimination

Pauli Nieminen ext-pauli.nieminen at nokia.com
Tue Dec 21 01:41:59 PST 2010


On 20/12/10 23:58 +0100, ext Soeren Sandmann wrote:
> Keith Packard <keithp at keithp.com> writes:
> 
> > On Mon, 20 Dec 2010 18:05:38 +0200, ville.syrjala at nokia.com wrote:
> > > Rather than continue my attempts to hack around the issue of incorrect
> > > ClipNotifys during window redirection changes, I decided to tackle the
> > > issue in more proper manner.
> > > 
> > > This series will remove the internal MapWindow+UnmapWindow cycle and
> > > replace it with a single ValidateTree+HandleExposures pass through
> > > the affected windows.
> > 
> > Thanks! As you might imagine, the whole unmap/map adventure was a short
> > cut to ensure that all of the regions ended up recomputed correctly:
> > 
> >  * compRedirectWindow
> >    + Redirected window has anything formerly obscured now exposed
> >    + Underlying windows are exposed where the redirected window was
> >      covering
> > 
> >  * compFreeClientWindow
> >    + Un-Redirected window gets painted from backing pixmap
> >    + Underlying window clip lists get updated
> >    
> > Do you have any small test cases that verify that these are working for
> > both manual and automatic redirect in each direction? I'm concerned that
> > the validation code won't 'just work' in all cases...
> 
> For what it's worth, there are some ancient bugs here:
> 
>         https://bugs.freedesktop.org/show_bug.cgi?id=5272
> 

Not fixed.

>         https://bugs.freedesktop.org/show_bug.cgi?id=5273
> 

Will be fixed with this patch set.

>         https://bugs.freedesktop.org/show_bug.cgi?id=5274
> 

I don't know. I would have to run the test case to see what goes wrong here.

>         https://bugs.freedesktop.org/show_bug.cgi?id=5275
> 

Not touching move code.

> about Composite and Damage that all have small test cases attached to
> them. 
> 
> I don't know whether these bugs are still relevant, in general or to
> the present patches.
> 
> 
> Soren
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel


More information about the xorg-devel mailing list