[PATCH:libICE] Fix stdio.h include for asprintf.
kibi at debian.org
Sun Dec 19 09:59:59 PST 2010
Alan Coopersmith <alan.coopersmith at oracle.com> (19/12/2010):
> Would it be better to just add AC_USE_SYSTEM_EXTENSIONS to
> configure.ac? That way it's set when testing for asprintf() in
> configure as well - something like (untested, just copied from
> libX11 configure.ac with a slight comment tweak):
I was particularly unhappy with having to introduce this special
case. Your solution just works and seems cleaner to me, thanks.
> diff --git a/configure.ac b/configure.ac
> index 03432f5..27c02ed 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -12,6 +12,11 @@ AC_CONFIG_HEADERS([config.h])
> AM_INIT_AUTOMAKE([foreign dist-bzip2])
> +# Set common system defines for POSIX extensions, such as _GNU_SOURCE
> +# Must be called before any macros that run the compiler (like
> +# AC_PROG_LIBTOOL or XORG_DEFAULT_OPTIONS) to avoid autoconf errors.
> # Require xorg-macros minimum of 1.10 for DocBook XML documentation
> [m4_fatal([must install xorg-macros 1.10 or later before running auto
Reviewed-by: Cyril Brulebois <kibi at debian.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 197 bytes
Desc: Digital signature
More information about the xorg-devel