[PATCH 2/2] mi: Sync: Don't free managed screen private

Daniel Stone daniel at fooishbar.org
Fri Dec 17 08:57:15 PST 2010


misync allocates space for its screen private with
dixRegisterPrivateKey, which means it doesn't have to free it at
CloseScreen time; doing so will, in fact, result in a crash.

Signed-off-by: Daniel Stone <daniel at fooishbar.org>
---
 miext/sync/misync.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/miext/sync/misync.c b/miext/sync/misync.c
index bcc68a2..50226d9 100644
--- a/miext/sync/misync.c
+++ b/miext/sync/misync.c
@@ -167,7 +167,6 @@ SyncCloseScreen (int i, ScreenPtr pScreen)
     SyncScreenPrivPtr pScreenPriv = SYNC_SCREEN_PRIV(pScreen);
 
     pScreen->CloseScreen = pScreenPriv->CloseScreen;
-    free(pScreenPriv);
 
     return (*pScreen->CloseScreen) (i, pScreen);
 }
-- 
1.7.2.3



More information about the xorg-devel mailing list