[PATCH xserver] X Sync Cleanups

James Jones jajones at nvidia.com
Wed Dec 15 14:29:49 PST 2010

On Wednesday 15 December 2010 2:24:07 pm James Jones wrote:
> Various cleanups identified during review of the
> X Sync Fence Object patches.
> -Correctly handle failure of AddResource()
> -Don't assert when data structures are corrupt.
> -Use the default switch label rather than reimplementing
>  it.
> -Re-introduce cast of result of dixAllocateObjectWithPrivate()
>  to kill an incompatible pointer type warning.
> -Remove comments claiming protocol updates are needed.  One
>  wasn't true and the other was addressed with a xextproto
>  change.
> -Return BadFence, not BadCounter from XSyncAwaitFence()
> Signed-off-by: James Jones <jajones at nvidia.com>
> ---
>  Xext/sync.c |  166
> ++++++++++++++++++++++++++++++++++++++++------------------- 1 files
> changed, 112 insertions(+), 54 deletions(-)

Keith, this patch should address all the concerns you brought up during 
review.  I decided not to use a union for the SyncObject struct.  I don't 
really find the casting excessive, and I like that it matches the 
Drawable/Window/Pixmap model.


More information about the xorg-devel mailing list