[RFC][PATCH] dix/mi/composite: Suppress ClipNotify during window redirection UnmapWindow

Adam Jackson ajax at nwnk.net
Tue Dec 14 12:57:18 PST 2010

On Mon, 2010-12-13 at 19:15 +0200, ville.syrjala at nokia.com wrote:
> From: Ville Syrjälä <ville.syrjala at nokia.com>
> When window redirection is changed, UnmapWindow() is called internally,
> which leads to windows temporarily getting unrealized. When a window is
> unrealized, ClipNotify() is called with an empty clip. In the case of
> Xv this leads to video overlays blinking off and on in a very annoying
> fashion. Suppress these ClipNotify() calls around the UnmapWindow()
> calls made from the composite code.
> Signed-off-by: Ville Syrjälä <ville.syrjala at nokia.com>
> ---
> I'm not 100% sure about the safety of this patch, hence to RFC. However
> it seems to me that all other windows whose clipping may be affected
> should get a ClipNotify via ValidateTree. And the redirected window
> itself will get a ClipNotity again when it gets remapped.

The result from this sounds reasonable and correct.  The implementation
should probably be a new CompositeClipNotify wrapper, rather than
forcing the knowledge into the fb layer.

- ajax
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-devel/attachments/20101214/7761e580/attachment.pgp>

More information about the xorg-devel mailing list