[PATCH modular 1/4] build.sh: remove CACHE env variable as it is not implementable

Gaetan Nadon memsize at videotron.ca
Mon Dec 13 17:04:22 PST 2010

On Mon, 2010-12-13 at 16:37 -0800, Alan Coopersmith wrote:

> Trevor Woerner wrote:
> > On Mon, Dec 13, 2010 at 7:03 PM, Gaetan Nadon <memsize at videotron.ca> wrote:
> >> The resulting variables XORG_CFLAGS and XORG_LIBS are unique to each package
> >> and hold different values.
> >> This is where I think the concept of a cache does not hold. The last write
> >> wins and if you pick a random
> >> package to rebuild, it will pick the value written last.
> > 
> > Ah okay, I think I see where you're going. In my original email I was
> > trying to say: "maybe all the variables between all the packages
> > should be coordinated so they don't clash" but seeing how huge of a
> > job that would be it's probably much safer this way. I'm guessing it's
> > probably not being used by many people, and I'm all for getting rid of
> > clutter :-)
> We tried that early on in modularization for all the libraries and apps,
> which is why they have strangely worded configure messages such as:
> checking for ICO... yes
> when you're building ico (it should really be "checking for the packages that
> ICO needs"), due to commits such as:
> http://cgit.freedesktop.org/xorg/app/ico/commit/?id=5c31a07dbcb735445951f7f7cae8579ee16262d5
> Unfortunately, it doesn't seem to have been consistently applied or kept up.

An impossible task, if you ask me. The cache should error out on

I assume it's an Acked-by from at least Trevor to remove this from
build.sh so new comers (or myself!)
don't get burned on this.

Thanks for the review!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20101213/73749e71/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-devel/attachments/20101213/73749e71/attachment.pgp>

More information about the xorg-devel mailing list