[PATCH libxkbcommon 00/11] Review configuration - Part 3

[Jeremy Huddleston]

For the series:

Reviewed-by: Jeremy Huddleston <jeremyhu at apple.com>

On Dec 11, 2010, at 17:08, Gaetan Nadon wrote:

> I left a couple of items to do:
> 1- add a paragraph in the README file describing what this library does
> 2- add the _X_EXPORT _X_HIDDEN where appropriate
> 
> Please check the tarball content to ensure no extra/missing files.
> The distcheck target now works.
> 
> Note that only srcdir is exported as an env var, not builddir.
> In the test scripts, $builddir will always be empty.
> 
> Gaetan Nadon (11):
>  config: relocate library functions check and comment
>  config: use xproto pkgconfig includex11dir variable
>  config: remove incorrectly implemented visibility compiler option
>  config: use existing variables KEYSYMDEF_H and XF86KEYSYM_H
>  config: makekeys prog should stand alone in the makekeys directory
>  config: add keysymdef and xf86keysym as dependencies of ks_tables.h
>  config: include: use nobase_include_HEADERS
>  config: make it easier to add TEST programs
>  config: distribute the .sh test programs and test data
>  config: set the default xkb config root based on xkeyboard-config
>    module
>  config: update COPYING for software licensing
> 
> COPYING                               |   48 ++++++++++++++++++++++++++++++++
> Makefile.am                           |    3 +-
> configure.ac                          |   49 ++++++++++++++++-----------------
> include/Makefile.am                   |    3 +-
> makekeys/.gitignore                   |    1 +
> makekeys/Makefile.am                  |    5 +++
> {src/makekeys => makekeys}/makekeys.c |    0
> src/.gitignore                        |    1 +
> src/Makefile.am                       |   10 +++++-
> src/makekeys/.gitignore               |    2 -
> src/makekeys/Makefile.am              |   13 ---------
> test/Makefile.am                      |   25 ++++++-----------
> 12 files changed, 99 insertions(+), 61 deletions(-)
> create mode 100644 makekeys/.gitignore
> create mode 100644 makekeys/Makefile.am
> rename {src/makekeys => makekeys}/makekeys.c (100%)
> create mode 100644 src/.gitignore
> delete mode 100644 src/makekeys/.gitignore
> delete mode 100644 src/makekeys/Makefile.am
> 
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel