[PATCH libxkbcommon 03/11] config: remove incorrectly implemented visibility compiler option

Gaetan Nadon memsize at videotron.ca
Sat Dec 11 17:08:32 PST 2010


CFLAGS is a user variable which should never be set by the configuration.
It allows the user to alter the configuration compiler options.

The visibility is only set for GNU compiler, leaving libraries built
with other compilers with the wrong visibility.

All other xorg libraries set visibilty using _X_EXPORT or _X_HIDDEN.

For the time being, all the symbols will have the default visibility
which does not break anything.

Signed-off-by: Gaetan Nadon <memsize at videotron.ca>
---
 configure.ac |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/configure.ac b/configure.ac
index 4fa9ea7..b982839 100644
--- a/configure.ac
+++ b/configure.ac
@@ -65,10 +65,6 @@ if test "x$CC_FOR_BUILD" = x; then
     fi
 fi
 
-if  test "x$GCC" = xyes ; then
-  CFLAGS="$CFLAGS -fvisibility=hidden"
-fi
-
 # Obtain protocols headers include directives
 PKG_CHECK_MODULES([X11], [xproto kbproto >= 1.0.5])
 
-- 
1.6.0.4



More information about the xorg-devel mailing list