[PATCH 1/2] Export xgiModuleData and DriverRec

Jesse Adkins jesserayadkins at gmail.com
Fri Dec 10 18:23:03 PST 2010


On Fri, Dec 10, 2010 at 11:38 AM, Paulo Zanoni <pzanoni at mandriva.com> wrote:
> You can't load the driver without exporting xgiModuleData.
> Most of the other drivers also export their DriverRecs.
>
> Signed-off-by: Paulo Zanoni <pzanoni at mandriva.com>
> ---
>  src/xgi_driver.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/xgi_driver.c b/src/xgi_driver.c
> index c149caa..b5899f2 100755
> --- a/src/xgi_driver.c
> +++ b/src/xgi_driver.c
> @@ -188,7 +188,7 @@ static const struct pci_id_match xgi_device_match[] = {
>  * an upper-case version of the driver name.
>  */
>
> -DriverRec XGI = {
> +_X_EXPORT DriverRec XGI = {
>     XGI_CURRENT_VERSION,
>     XGI_DRIVER_NAME,
>     XGIIdentify,
> @@ -377,7 +377,7 @@ static XF86ModuleVersionInfo xgiVersRec = {
>     {0, 0, 0, 0}
>  };
>
> -XF86ModuleData xgiModuleData = { &xgiVersRec, xgiSetup, NULL };
> +_X_EXPORT XF86ModuleData xgiModuleData = { &xgiVersRec, xgiSetup, NULL };
>
>  /*** static string ***/
>  #ifdef XGIMERGED
> --
> 1.7.1
>
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel
>

Yes! xgi certainly needs some work done on it.

Reviewed-by: Jesse Adkins <jesserayadkins at gmail.com>


More information about the xorg-devel mailing list