[PATCH 1/4] Fix dmx linking.

Julien Cristau jcristau at debian.org
Tue Dec 7 09:08:43 PST 2010


On Tue, Dec  7, 2010 at 08:10:37 -0800, Keith Packard wrote:

> On Fri, 3 Dec 2010 18:16:47 +0100, Cyril Brulebois <kibi at debian.org> wrote:
> > Cyril Brulebois <kibi at debian.org> (12/11/2010):
> > > Turn glxproxy.a into glxproxy.la, and add an explicit dependency on dix.
> > > 
> > > Signed-off-by: Cyril Brulebois <kibi at debian.org>
> > 
> > Could I please get a review for one of those patches?
> >   [PATCH 1/4] Fix GLX_LIBS vs. DMX_LIBS order.
> >   [PATCH 1/4] Fix dmx linking.
> 
> Neither looks dangerous, but I don't know anything about the issues
> they're trying to address. Anyone else have a clue about DMX?
> 
IIRC the problem was that once (core) dmx got rid of the deprecated
functions, the linker would discard dix/deprecated.o before seeing
glxProxy/libglxproxy.a, which did need it.

I think I'd go for the first patch just because it's simpler.  So add my
Reviewed-by: Julien Cristau <jcristau at debian.org>
for it.

Cheers,
Julien
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg-devel/attachments/20101207/ff6c2f9a/attachment.pgp>


More information about the xorg-devel mailing list