[PATCH xserver (v3) 00/10] X Server support for Fence Sync

Keith Packard keithp at keithp.com
Mon Dec 6 18:26:29 PST 2010

On Mon, 6 Dec 2010 14:59:17 -0800, James Jones <jajones at nvidia.com> wrote:

> Took me a while to re-verify, but it's reworked and ready for review again.  
> Thanks for the feedback.  Note it won't help a lot with bisect because XSync 
> wasn't using protocol-versions.h, but it is better organized now.  I avoided 
> squashing too many commits because I didn't want to make the individual 
> patches too large, or change and move the same code in one commit (kills diff 
> readability).

The patch series was quite readable, and there's not much to be done
about the broken protocol-versions.h stuff. Thanks for getting that
applied first.

I think this is ready for merging; the only potential change would be to
use a union type instead of casts for all of the subtyping with sync
objects  vs counters/fences. We should be able to clean that up later
though, if you think it's a reasonable plan.

keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20101206/fec8cbce/attachment.pgp>

More information about the xorg-devel mailing list