[PATCH s3] Add missing call to vbeFree (bug 4417)

Matt Turner mattst88 at gmail.com
Sat Dec 4 07:35:57 PST 2010

On Sat, Dec 4, 2010 at 2:18 AM, Jesse Adkins <jesserayadkins at gmail.com> wrote:
> I should have been more clear. I really was wondering why there's a
> vbeInit right before a vbeFree. It seems like that would end up being
> a rather long no-op.
> It looks like the vbe pointer is never used by the driver, and that
> this would result in everything vbe creates being freed. Assuming you
> have this hardware, why not try to remove the vbe stuff entirely? If
> that fails, what about substituting the vbeInit with the stuff under
> int10 (the xf86InitInt10).

I don't have the hardware.

Worst case, we commit the patch and don't leak a few bytes of memory.
I'll let someone else actually verify the vbe stuff does something.

More information about the xorg-devel mailing list