[PATCH elographics 0/7] cleanup and abi 12 support

Cyril Brulebois kibi at debian.org
Sat Dec 4 05:44:16 PST 2010


Peter Hutterer <peter.hutterer at who-t.net> (03/12/2010):
> as subject, untested, no device.

(me too)

Patch 1 to 6: applied incrementally, builds successfully against 1.9
→ Reviewed-by: Cyril Brulebois <kibi at debian.org>

Patch 7: fails against 1.9, needs an ABI check to bail out cleanly:
| xf86Elo.c: In function ‘xf86EloControl’:
| xf86Elo.c:729: error: too many arguments to function ‘InitValuatorAxisStruct’
| xf86Elo.c:736: error: too many arguments to function ‘InitValuatorAxisStruct’

Patch 7: OK against server's master, with a suggestion: the compiler
catches default_options is defined but not used. Looking at mutouch
again, it looks like you may want to add it to this declaration:
| _X_EXPORT InputDriverRec ELOGRAPHICS = {
|     1,                          /* driver version */
|     "elographics",              /* driver name */
|     NULL,                       /* identify */
|     xf86EloInit,                /* pre-init */
|     xf86EloUninit,              /* un-init */
|     NULL,                       /* module */
| };

Mraw,
KiBi.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg-devel/attachments/20101204/91cb1f8a/attachment.pgp>


More information about the xorg-devel mailing list