[PATCH libXext (rev3) 1/5] Backwards compat for newer XSync + older servers

Julien Cristau jcristau at debian.org
Thu Dec 2 10:35:27 PST 2010


On Thu, Dec  2, 2010 at 09:26:27 -0800, James Jones wrote:

> +    for (i = 0; i < NUM_VERSIONS; i++) {
> +	if (supported_versions[i].major == rep.majorVersion &&
> +	    supported_versions[i].minor == rep.minorVersion) {
> +	    return &supported_versions[i];
> +	}
> +    }
> +
Should this look for the highest pair that has major == rep.majorVersion
and minor <= rep.minorVersion, so you don't need to add every minor
version that doesn't change the number of errors?

Cheers,
Julien


More information about the xorg-devel mailing list