rendercheck segfaults [Re: rendercheck: 10 commits]

[Aaron Plattner]

On Wed, Dec 01, 2010 at 01:47:47PM -0800, Chris Wilson wrote:
> On Wed, 1 Dec 2010 13:06:47 -0800, Aaron Plattner <aplattner at nvidia.com> wrote:
> > This series causes a segmentation fault in blend_test because the loop
> > at the top of the "while (k < num_dst)" loop doesn't ever increment y
> > because num_src is 325 and win_height is only 200.
> 
> I've pushed a fixed version of blend and composite that I tested with
> windows both larger and smaller than num_src.

Thanks, Chris.  Unfortunately, it still crashes later:

(gdb) b t_blend.c:80
Breakpoint 1 at 0x406cc5: file t_blend.c, line 80.
(gdb) condition 1 y == 0
(gdb) r
Starting program: /home/aaron/git/x/app/rendercheck/rendercheck 
rendercheck 1.4
Render extension version 0.11
Window format: r8g8b8
Found server-supported format: a8
Found server-supported format: a8r8g8b8
Found server-supported format: x8r8g8b8
Found server-supported format: b8g8r8a8
Found server-supported format: b8g8r8x8
Found server-supported format: r8g8b8
Found server-supported format: b8g8r8
Found server-supported format: r5g5b5
Found server-supported format: b5g5r5
Found server-supported format: x1r5g5b5
Found server-supported format: x1b5g5r5
Found server-supported format: r5g6b5
Found server-supported format: b5g6r5
Found server-supported format: x8b8g8r8
Found server-supported format: x2r10g10b10
Found server-supported format: x2b10g10r10
Found server-supported format: a8
Found server-supported format: a8r8g8b8
Found server-supported format: x8r8g8b8
Found server-supported format: b8g8r8a8
Found server-supported format: b8g8r8x8
Found server-supported format: r8g8b8
Found server-supported format: b8g8r8
Found server-supported format: r5g5b5
Found server-supported format: b5g5r5
Found server-supported format: x1r5g5b5
Found server-supported format: x1b5g5r5
Found server-supported format: r5g6b5
Found server-supported format: b5g6r5
Found server-supported format: x8b8g8r8
Found server-supported format: x2r10g10b10
Found server-supported format: x2b10g10r10
Beginning testing of filling of 1x1R pictures
Beginning testing of filling of 10x10 pictures
Beginning dest coords test
Beginning src coords test
Beginning mask coords test
Beginning transformed src coords test
Beginning transformed src coords test 2
Beginning transformed mask coords test
Beginning transformed mask coords test 2
Beginning blend test on a8

Breakpoint 1, blend_test (dpy=0x610010, win=0x7fffffffe070, dst=0x61e730, op=0x628030, num_op=38, 
    src_color=0x6280d0, num_src=325, dst_color=0x629510, num_dst=165) at t_blend.c:80
80                          image = XGetImage(dpy, dst->d,
(gdb) i local
image = 0x629a60
k0 = 165
this_src = 163
rem_src = 163
expected = {r = 0, g = 0, b = 0, a = 0.49803921568627452}
tested = {r = 0, g = 0, b = 0, a = 0.50196078431372548}
tdst = {r = 0, g = 0, b = 0, a = 0.50196078431372548}
testname = "\200g\211\367\377\177\000\000\004\000\000\000\000\000\000\000\004\000\000"
i = 38
j = 162
k = 165
y = 0
iter = 1
page = 1
num_pages = 2
(gdb) c
Continuing.

Program received signal SIGSEGV, Segmentation fault.
0x0000000000407112 in blend_test (dpy=0x610010, win=0x7fffffffe070, dst=0x61e730, op=0x628030, num_op=38, 
    src_color=0x6280d0, num_src=325, dst_color=0x629510, num_dst=165) at t_blend.c:135
135                         XDestroyImage(image);
(gdb) p image
$23 = (XImage *) 0x0