[PATCH 3/6] xfree86: fbdevhw: remove superfluous pci pointer from probe function

Tiago Vignatti vignatti at freedesktop.org
Thu Aug 26 11:56:03 PDT 2010


2010/8/26 Mark Kettenis <mark.kettenis at xs4all.nl>:
>> From: Tiago Vignatti <tiago.vignatti at nokia.com>
>> Date: Thu, 26 Aug 2010 18:37:31 +0300
>>
>> The only drivers using this function are fbdev and glint. Though those driver
>> initialize with NULL argument. Other drivers do some kind of implicit probe
>> using fbdevHWInit instead.
>
> I can see why fbdev needs this, but what makes glint so special that
> it does things different than all the other drivers?

I dunno. This patch is just a cleaning up and this information doesn't
actually matter. You seems to be running out of the subject.


>> API break.
>
> So after this, glint is broken?  If you think this API change is so
> important, I think you should take the trouble to fix the driver
> first, or at least at the same time.

The server is in a development process and is natural to happens
quickly breaks like this. Of course I'll fix them. Patches for the
drivers are coming next.

     Tiago


More information about the xorg-devel mailing list