[PATCH] Return Success from generate_modkeymap() when max_keys_per_mod is zero

[Pat Kane]

 > I've also checked parts of Xorg source which might be affected by this
 > change (because returned modkeymap can be NULL with the patch) and
 > this change doesn't cause any problem.

I checked the two places that call generate_modkeymap() and I agree that
they can deal with the change okay.

Reviewed-by: Patrick E. Kane <pekane52 at gmail.com>

On Wed, Aug 25, 2010 at 3:38 AM, Adam Tkac <atkac at redhat.com> wrote:
> Hello,
>
> simple patch which corrects dix/inpututils.c:generate_modkeymap()
> function is attached. Current generate_modkeymap function is broken
> and returns BadAlloc when keyboard has no modifiers (i.e.
> max_keys_per_mod is zero).
>
> Although this bug has no effect for Xorg server ifself, it has effect
> for Xvnc VNC server.
>
> I've also checked parts of Xorg source which might be affected by this
> change (because returned modkeymap can be NULL with the patch) and
> this change doesn't cause any problem.
>
> Patch applies to server-1.9-branch but apply it also to server-1.8-branch
> and server-1.7-branch branches, please.
>
> Regards, Adam
>
> --
> Adam Tkac, Red Hat, Inc.
>
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel
>