[PATCH] use CLOCK_MONOTONIC_COARSE posix timer instead of CLOCK_MONOTONIC in Xorg

[Alan Coopersmith]

ykzhao wrote:
> On Mon, 2010-08-23 at 23:25 +0800, Adam Jackson wrote:
>> On Mon, 2010-08-23 at 10:23 +0200, Mark Kettenis wrote:
>>>> From: yakui.zhao at intel.com
>>>> Date: Mon, 23 Aug 2010 15:20:05 +0800
>>>> From: Zhao Yakui <yakui.zhao at intel.com>
>>>>
>>>> ---
>>>>  os/utils.c |   14 +++++++++++++-
>>>>  1 files changed, 13 insertions(+), 1 deletions(-)
>>>>
>>>> diff --git a/os/utils.c b/os/utils.c
>>>> index 51455cc..a08d591 100644
>>>> --- a/os/utils.c
>>>> +++ b/os/utils.c
>>>> @@ -242,6 +242,10 @@ OsSignal(int sig, OsSigHandlerPtr handler)
>>>>  #endif
>>>>  #endif
>>>>  
>>>> +#ifndef CLOCK_MONOTONIC_COARSE
>>>> +#define CLOCK_MONOTONIC_COARSE 6
>>>> +#endif
>>> What if an OS doesn't have CLOCK_MONOTONIC_COARSE, but uses the clock
>>> ID 6 for some other purpose?
>> Then this patch would be wrong.
>>
>> NAK on that basis.
> 
> Yes. Agree.
> 
> How about using the constant value(6) directly? 

That's the part that's wrong, assuming 6 will always mean
CLOCK_MONOTONIC_COARSE.   Perhaps if it's now part of the Linux ABI,
you could do it inside an #ifdef linux, but you can't assume that
value means anything useful on a non-linux kernel.

-- 
	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System