[PATCH] Fix property and selection devPrivate allocation.

[Justin P. Mattock]

On 08/23/2010 01:14 PM, Adam Jackson wrote:
> On Mon, 2010-08-23 at 16:04 -0400, Eamon Walsh wrote:
>> Selection objects were not being allocated with privates, and both
>> objects had a stray statement that zeroed out the devPrivates field.
>>
>> Signed-off-by: Eamon Walsh<ewalsh at tycho.nsa.gov>
>> Reported-by: Justin Mattock<justinmattock at gmail.com>
>
> Reviewed-by: Adam Jackson<ajax at redhat.com>
>
> - ajax

patch applied.. seems the crash happens a little later now after 
applying. i.e.  gdm starts(nice picture screen) I login, then a 
picture(hear things activating) then everything craps out.

heres what Xorg.0.log has in it:

[    38.868] (II) config/udev: Adding input device Built-in iSight
(/dev/input/event6)
[    38.868] (**) Built-in iSight: Applying InputClass "evdev keyboard 
catchall"
[    38.868] (**) Built-in iSight: always reports core events
[    38.868] (**) Built-in iSight: Device: "/dev/input/event6"
[    38.871] (--) Built-in iSight: Found keys
[    38.871] (II) Built-in iSight: Configuring as keyboard
[    38.871] (II) XINPUT: Adding extended input device "Built-in
iSight" (type: KEYBOARD)
[    38.871] (**) Option "xkb_rules" "evdev"
[    38.871] (**) Option "xkb_model" "evdev"
[    38.871] (**) Option "xkb_layout" "us"
[    54.426]
Backtrace:
[    54.426] 0: /usr/bin/X (xorg_backtrace+0x26) [0x49e486]
[    54.426] 1: /usr/bin/X (0x400000+0x60f19) [0x460f19]
[    54.426] 2: /lib/libpthread.so.0 (0x7f6205c93000+0xfa50) 
[0x7f6205ca2a50]
[    54.426] 3: /usr/bin/X (0x400000+0x7cae0) [0x47cae0]
[    54.427] 4: /usr/bin/X (FreeColormap+0x27) [0x497677]
[    54.427] 5: /usr/bin/X (FreeClientResources+0xdb) [0x44b6bb]
[    54.427] 6: /usr/bin/X (FreeAllResources+0x46) [0x44b776]
[    54.427] 7: /usr/bin/X (0x400000+0x22924) [0x422924]
[    54.427] 8: /lib/libc.so.6 (__libc_start_main+0xed) [0x7f620414365d]
[    54.427] 9: /usr/bin/X (0x400000+0x224a1) [0x4224a1]
[    54.427] Segmentation fault at address 0x31
[    54.427]
Fatal server error:
[    54.427] Caught signal 11 (Segmentation fault). Server aborting
[    54.427]
[    54.427]
Please consult the The X.Org Foundation support
	 at http://wiki.x.org
  for help.
[    54.427] Please also check the log file at "/var/log/Xorg.0.log"
for additional information.
[    54.427]
[    54.434] (II) Power Button: Close
[    54.434] (II) UnloadModule: "evdev"
[    54.440] (II) Power Button: Close
[    54.440] (II) UnloadModule: "evdev"
[    54.446] (II) Sleep Button: Close
[    54.446] (II) UnloadModule: "evdev"
[    54.452] (II) Apple Inc. Apple Keyboard: Close
[    54.452] (II) UnloadModule: "evdev"
[    54.458] (II) Apple Inc. Apple Keyboard: Close
[    54.458] (II) UnloadModule: "evdev"
[    54.464] (II) Mitsumi Electric Apple Optical USB Mouse: Close
[    54.464] (II) UnloadModule: "evdev"
[    54.470] (II) Built-in iSight: Close
[    54.470] (II) UnloadModule: "evdev"


let me know if you need any info from a log or something.

Justin P. Mattock