[PATCH] XOpenDisplay: save the correct display_name value

[jamey at minilop.net]

On Mon, Aug 16, 2010 at 9:34 AM, Aaron Plattner <aplattner at nvidia.com> wrote:
> The X Test Suite's XDisplayString test checks the invariant
> XDisplayString(XOpenDisplay(str)) == str.  The XCB-based XOpenDisplay violates
> this invariant by expanding str to the canonical form "host:display.scrn"
> (unless HAVE_LAUNCHD is set and it starts with "/tmp/launch").  E.g., this
> expands ":1" to ":1.0":

I don't understand. As far as I can tell, the non-XCB variant set
dpy->display_name exactly the same way: See the uses of fullnamep in
ConnDis.c:_X11TransConnectDisplay. I certainly didn't write extra code
for re-formatting a display string just for fun. :-)

I'm not opposed to this patch, since I'm always in favor of deleting
code--but since this seems to have been Xlib's behavior ever since the
import into git, I'm not sure it's a good idea.

At the least, I'd appreciate the commit message reflecting that the
bug has nothing to do with XCB. :-)

Jamey