[PATCH v3] dix: copy the valuators passed into GPE/GKVE/GProxE.

Peter Hutterer peter.hutterer at who-t.net
Sun Aug 15 21:04:52 PDT 2010


On Fri, Aug 13, 2010 at 12:00:06AM -0700, Keith Packard wrote:
> On Fri, 13 Aug 2010 16:47:46 +1000, Peter Hutterer <peter.hutterer at who-t.net> wrote:
> 
> > May be too late for 1.9 though it shouldn't have any affect. as long as we
> > keep supporting multiple server versions in the drivers, no driver can
> > sanely rely on this anyway.
> > alloca could be replaced with a simple int valuators[MAX_VALUATOR] if
> > desired.
> 
> Yes please. MAX_VALUATOR is only 36. My question is whether any driver
> in the katamari will require this patch; if so, we should probably
> include it as it's reasonably obvious.

require? no, otherwise we'd have noticed it long ago. I only noticed this
when implementing button emulation code in the wacom driver.

However, since the input drivers support multiple server versions the
earlier the patch goes into a release, the better. less ifdef chaos.

Cheers,
  Peter


More information about the xorg-devel mailing list