[PATCH] xace: Invalid reference to out-of-scope data.

Adam Jackson ajax at nwnk.net
Tue Aug 10 08:25:04 PDT 2010


On Tue, 2010-08-10 at 09:38 +0100, Chris Wilson wrote:

> diff --git a/Xext/xace.c b/Xext/xace.c
> index e10d837..c757cad 100644
> --- a/Xext/xace.c
> +++ b/Xext/xace.c

This hunk looks correct.
 
> diff --git a/hw/xfree86/modes/xf86Crtc.c b/hw/xfree86/modes/xf86Crtc.c
> index b2daec7..3cbaa08 100644
> --- a/hw/xfree86/modes/xf86Crtc.c
> +++ b/hw/xfree86/modes/xf86Crtc.c
> @@ -1393,7 +1393,13 @@ xf86ModeCompare (DisplayModePtr a, DisplayModePtr b)
>      if (diff)
>  	return diff;
>      diff = b->Clock - a->Clock;
> -    return diff;
> +    if (diff)
> +	    return diff;
> +    if (a->Private)
> +	    return -1;
> +    if (b->Private)
> +	    return 1;
> +    return 0;
>  }
>  
>  /**

This hunk looks unrelated.

- ajax
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100810/64f60c5c/attachment.pgp>


More information about the xorg-devel mailing list