[PATCH xextproto 0/4] XSync Fence Objects

[Alan Coopersmith]

James Jones wrote:
> Adds support for binary sync objects.  Objects are set to
> "triggered" using X commands that are executed relative to
> X rendering commands.  Clients can wait for fence sync
> objcts to reach the triggered state using XSync APIs or
> using interop functionality in other APIs.  This allows
> for efficient cross-API synchronization with X rendering
> operations.

I don't know enough about sync to comment on specifics, but some
general notes:

 - since you're increasing the number of errors, see the pain
   Peter recently went through when doing this with Xinput to
   not break old clients that allocate a smaller number of error
   slots.

 - updates to protocols to add new requests/errors should also
   be reflected in the docs & xcb protocol specs.  The Sync
   extension spec is now in DocBook format as specs/sync.xml
   in xextproto.  The xcb protocol specs are in src/sync.xml
   in xcb-proto.

 - is there some reason patch 4 wasn't squashed into patch 1?
   adding a new member in the middle of a request structure
   doesn't seem like a safe operation, and you'd never want to
   build a version without it

-- 
	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System