[PATCH app-xkbutils 3/4] config: update directs dependencies for xkbbell

Alan Coopersmith alan.coopersmith at oracle.com
Sun Aug 8 09:13:37 PDT 2010


Gaetan Nadon wrote:
> Depends on xproto through the inclusion of Xproto.h.
> Depends on inputproto through the inclusion of XI.h
> Depends on x11 through the inclusion of Xlib.h.
> Does not depend on xkbfile for headers or libs.
> 
> Signed-off-by: Gaetan Nadon <memsize at videotron.ca>
> ---
>  configure.ac |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index f2bfa2d..e45f6b6 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -40,7 +40,7 @@ AC_PROG_INSTALL
>  
>  # Obtain compiler/linker options from depedencies
>  PKG_CHECK_MODULES(XKBVLEDS, xaw7)
> -PKG_CHECK_MODULES(XKBBELL, xkbfile x11 inputproto)
> +PKG_CHECK_MODULES(XKBBELL, xproto inputproto x11)
>  PKG_CHECK_MODULES(XKBWATCH, xaw7)
>  
>  AC_OUTPUT([Makefile])

While it might make sense to add an xkbbell option to specify the
bell name from libxkbfile's XKBbells.h, that's not done now, so
the dependency can be removed.   (It would also make sense if
XKBbells.h was not part of libxkbfile, which appears to be just
"an undocumented private library we can hide this in until we
 decide if it's ready for libX11" - a number of the other X apps
do have conditional code to use it, some of which got broken in
the imake -> autoconf conversion.)

-- 
	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System



More information about the xorg-devel mailing list