[PATCH 6/6] Clean up Xext/Makefile.am

Tomas Carnecky tom at dbservice.com
Wed Aug 4 05:31:02 PDT 2010


On 8/3/10 7:27 PM, Jamey Sharp wrote:
> One note on this patch:
> 
> On Sun, Aug 01, 2010 at 09:28:23PM +0200, Tomas Carnecky wrote:
>> -INCLUDES = -I$(top_srcdir)/hw/xfree86/dixmods/extmod @XORG_INCS@
>> +INCLUDES = @XORG_INCS@
> 
> Doesn't this change belong in the earlier patch that deletes the extmod
> directory?

Yep, I moved that to the other patch. But there are more extmod
leftovers. A couple comments in source files and a few other makefiles
that use this include path. I have another patch which cleans all these
places up.

However, one place where extmod is still used is the (sample) xorg.conf
file (hw/xfree86/xorgconf.cpp and hw/xfree86/doc/man/xorg.conf.man.pre).
Extmod is used to illustrate how to pass options to modules:

SubSection  "extmod"
  Option  "omit xfree86-dga"
EndSubSection

What should be done with that? Remove completely? AFAICS no other module
accepts or uses those module-specific options.

tom



More information about the xorg-devel mailing list