[PATCH 3/6] xfree86: Simplify xf86Msg{,Verb}
Mark Kettenis
mark.kettenis at xs4all.nl
Wed Aug 4 00:50:52 PDT 2010
> From: Jesse Adkins <jesserayadkins at gmail.com>
> Date: Tue, 3 Aug 2010 18:21:30 -0700
>
> Previously, the functions would call xf86VDrvMsgVerb with a screen of -1
> despite their comments saying they were for "non-driver messages".
> They now call LogVMessageVerb, which is what xf86VDrvMsgVerb does anyway
> when it has a screen == -1.
>
> Signed-off-by: Jesse Adkins <jesserayadkins at gmail.com>
Makes sense to me.
Reviewd-by: Mark Kettenis <kettenis at openbsd.org>
> hw/xfree86/common/xf86Helper.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/xfree86/common/xf86Helper.c b/hw/xfree86/common/xf86Helper.c
> index 07f9f0a..90e0c67 100644
> --- a/hw/xfree86/common/xf86Helper.c
> +++ b/hw/xfree86/common/xf86Helper.c
> @@ -1267,7 +1267,7 @@ xf86MsgVerb(MessageType type, int verb, const char *format, ...)
> va_list ap;
>
> va_start(ap, format);
> - xf86VDrvMsgVerb(-1, type, verb, format, ap);
> + LogVMessageVerb(type, verb, format, ap);
> va_end(ap);
> }
>
> @@ -1278,7 +1278,7 @@ xf86Msg(MessageType type, const char *format, ...)
> va_list ap;
>
> va_start(ap, format);
> - xf86VDrvMsgVerb(-1, type, 1, format, ap);
> + LogVMessageVerb(type, 1, format, ap);
> va_end(ap);
> }
More information about the xorg-devel
mailing list