[PATCH] xfree86: Loader: Don't print loader 'magic'.

[Matt Turner]

On Mon, Aug 2, 2010 at 11:57 AM, Adam Jackson <ajax at nwnk.net> wrote:
> On Sun, 2010-08-01 at 16:01 -0700, Jesse Adkins wrote:
>> xorg_symbols has nothing to do with module loading.
>> Signed-off-by: Jesse Adkins <jesserayadkins at gmail.com>
>
> Be very very careful in doing this.  I'm inclined to nak this on
> principle.
>
> The issue is that some symbols need to be included in the server so they
> can be exported to drivers.  This is why we have a big table referencing
> them all.  The problem then is making sure the _table_ is referenced,
> otherwise the linker can GC it away (and then GC away all the symbols it
> references...).  Passing it to a print function is enough of a side
> effect to make sure it sticks around in the final link.
>
> There is assuredly a better way to do this for sensible toolchains, but
> instead we're using libtool.
>
> - ajax

This is the kind of magic and knowledge that needs to be in a comment
right beside the xf86MsgVerb Loader magic line.

Matt