[PATCH] xfree86: Plug a leak in OpenConfigFile. Signed-off-by: Jesse Adkins <jesserayadkins at gmail.com>

Peter Hutterer peter.hutterer at who-t.net
Sun Aug 1 20:52:16 PDT 2010


On Sun, Aug 01, 2010 at 04:01:25PM -0700, Jesse Adkins wrote:
> ---
>  hw/xfree86/parser/scan.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/hw/xfree86/parser/scan.c b/hw/xfree86/parser/scan.c
> index 5312143..e861d6c 100644
> --- a/hw/xfree86/parser/scan.c
> +++ b/hw/xfree86/parser/scan.c
> @@ -819,6 +819,7 @@ OpenConfigFile(const char *path, const char *cmdline, const char *projroot,
>  		}
>  	}
>  
> +    free(pathcopy);

broken indentation

>  	if (file) {
>  		configFiles[numFiles].file = file;
>  		configFiles[numFiles].path = strdup(filepath);
> -- 
> 1.7.0.4
> 

OpenConfigDir suffers from the same leak. Please fix this up in the same
patch. Given that, Reviewed-by: Peter Hutterer <peter.hutterer at who-t.net>



Cheers,
  Peter


More information about the xorg-devel mailing list