[PATCH] xfree86: Remove unused kbdCustomKeycodes from xf86Info. Signed-off-by: Jesse Adkins <jesserayadkins at gmail.com>
Peter Hutterer
peter.hutterer at who-t.net
Sun Aug 1 20:35:00 PDT 2010
On Sun, Aug 01, 2010 at 04:01:20PM -0700, Jesse Adkins wrote:
> ---
> hw/xfree86/common/xf86Globals.c | 1 -
> hw/xfree86/common/xf86Privstr.h | 1 -
> 2 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/hw/xfree86/common/xf86Globals.c b/hw/xfree86/common/xf86Globals.c
> index 0ff0849..a11cbc8 100644
> --- a/hw/xfree86/common/xf86Globals.c
> +++ b/hw/xfree86/common/xf86Globals.c
> @@ -124,7 +124,6 @@ xf86InfoRec xf86Info = {
> #endif
> .pmFlag = TRUE,
> .log = LogNone,
> - .kbdCustomKeycodes = FALSE,
> .disableRandR = FALSE,
> .randRFrom = X_DEFAULT,
> #if defined(CONFIG_HAL) || defined(CONFIG_UDEV)
> diff --git a/hw/xfree86/common/xf86Privstr.h b/hw/xfree86/common/xf86Privstr.h
> index 1321d2c..f2f3f11 100644
> --- a/hw/xfree86/common/xf86Privstr.h
> +++ b/hw/xfree86/common/xf86Privstr.h
> @@ -95,7 +95,6 @@ typedef struct {
> #endif
> Bool pmFlag;
> Log log;
> - Bool kbdCustomKeycodes;
> Bool disableRandR;
> MessageType randRFrom;
> Bool aiglx;
> --
> 1.7.0.4
same here, please add an empty line in the commit message.
fwiw, kbdCustomKeycodes became obsolete with
3eeb62e8f587732e6b433c2b9c6879eb26a3f1b4 "bug #890: completely remove
deprecated keyboard driver". Please add that to the commit message.
This removal changes the ABI of an exported symbol, and it looks like it's
only the keyboard drivers and the mouse driver using it. Once you've fixed
up the commit message, please CC me on the patch and I'll merge it into my
next branch (which already has the next input ABI).
Reviewed-by: Peter Hutterer <peter.hutterer at who-t.net> otherwise though
Cheers,
Peter
More information about the xorg-devel
mailing list