[PATCH] evdev: add phys property (EVIOCGPHYS) as stable identifier
Peter Korsgaard
jacmet at sunsite.dk
Wed Apr 28 08:13:10 PDT 2010
>>>>> "Peter" == Peter Hutterer <peter.hutterer at who-t.net> writes:
Hi,
>> EVIOCGPHYS is evdev specific ofcourse, but I guess we could parse
>> the commonOptions and add the device property in
>> xf86ProcessCommonOptions().
>>
>> Does that sound good to you?
Peter> yeah, that's what I had in mind. two-string property, one being
Peter> the /dev/input/XXX string, the second one being the Phys (if
Peter> available)
Ok, good.
>> Really? That sounds like a bug in valgrind then. EVIOCGPHYS is correctly
>> marked as an input ioctl (_IOC(_IOC_READ, 'E', 0x07, len)), so it should
>> know that phys contains valid data after the ioctl.
>>
>> But I can certainly add the initializer, even though it's unneeded
>> bloat.
Peter> I'll double-check again, but I saw those warnings this
Peter> morning. Don't know which distro and what version of valgrind
Peter> though...
I had a look, and it was a bug in valgrind. I sent them a patch:
http://thread.gmane.org/gmane.comp.debugging.valgrind.devel/11049
Peter> meanwhile, the 6 extra bytes won't make a difference ;)
Sorry, I'm coming from a kernel/busybox/embedded background, I'm used to
care about such things ;)
Why do you expect it to take up 6 bytes? I would expect it would have to
copy 256 bytes from somewhere to initialize unless gcc is clever.
.. Which it is, it ends up doing a rep stos loop - Which adds something
like 10-15 bytes.
I'll add the initializer and resend.
--
Bye, Peter Korsgaard
More information about the xorg-devel
mailing list