[PATCH imake 4/4] mkdirheir: ignore empty components created by extra slashes

Alan Coopersmith alan.coopersmith at oracle.com
Tue Apr 27 17:55:23 PDT 2010


Yaakov (Cygwin/X) wrote:
> diff --git a/mkdirhier b/mkdirhier
> index 09b89ee..c33c389 100644
> --- a/mkdirhier
> +++ b/mkdirhier
> @@ -43,6 +43,10 @@ do
>  
>  	for filename
>  	do
> +		if [ "$filename" = '' ]; then
> +			continue
> +		fi
> +
>  		path=$prefix$filename
>  		prefix=$path/
>  		shift

Seems reasonable to me, so:
 Reviewed-by: Alan Coopersmith <alan.coopersmith at oracle.com>

though I've been wondering if we shouldn't just have the script
call mkdir -p on modern systems.   (We stopped shipping mkdirheir
for a bit, but got complaints about old Makefiles that stopped
working and since it appears to be in most distros still, and
has almost no maintenance cost, didn't seem worth arguing over.)

AC_PROG_MKDIR_P checks if we can call mkdir -p, but I don't see
a good way to check its result.

-- 
	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System



More information about the xorg-devel mailing list